posix: fs: refactor posix_file_system_r #83395
Merged
+106
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a NULL pointer was passed as the second argument to readdir_r(). This is incorrect. The passed pointer should be to a valid, externally-allocated struct direct. Signed-off-by: Chris Friedt <[email protected]>
Move struct posix_fs_desc to fs_priv.h Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
fix-readdir-r
branch
3 times, most recently
from
db11023 to
a104447
Compare
cfriedt
changed the title
cfriedt
force-pushed
the
fix-readdir-r
branch
2 times, most recently
from
7dbd1fb to
05cdff0
Compare
cfriedt
force-pushed
the
fix-readdir-r
branch
from
05cdff0 to
75f9e6a
Compare
cfriedt
added
the
area: Tests
cfriedt
force-pushed
the
fix-readdir-r
branch
from
75f9e6a to
796e268
Compare
9 tasks
nandojve
requested changes
Jan 1, 2025
The default stack size was causing qemu_arc/qemu_arc_em and qemu_arc/qemu_arc_hs to fail when a dirent object was stack-allocated. Increase the default stack size to accomodate for additional usage. Signed-off-by: Chris Friedt <[email protected]>
Move the functionality of POSIX_FILE_SYSTEM_R to its own compilation unit and remove the unnecessary dependency on POSIX_FILE_SYSTEM. Signed-off-by: Chris Friedt <[email protected]>
ycsin
approved these changes
Jan 1, 2025
nandojve
approved these changes
Jan 1, 2025
kartben
approved these changes
Jan 2, 2025
kartben
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: posix: fs: increase ztest stack size from 1k to 2k
correct arguments to
readdir_r()intests/posix/fs/src/test_fs_dir.cmove
struct posix_fs_desctofs_priv.hmove
POSIX_FILE_SYSTEM_Rcode tofile_system_r.cand separate Kconfig